Updates to FlaskAppBuilder 3.3.2+ #17208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
update-flask-appbuilder-to-3.3.2
branch
from
6256f00
to
dd4a1ab
Compare
potiuk
force-pushed
the
update-flask-appbuilder-to-3.3.2
branch
from
dd4a1ab
to
c722557
Compare
kaxil
approved these changes
Jul 27, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
|
REbuilding |
zhongjiajie
approved these changes
Jul 27, 2021
potiuk
force-pushed
the
update-flask-appbuilder-to-3.3.2
branch
from
c722557
to
12a2311
Compare
|
I was hoping this would get us to SQLAlchemy 1.4, but alas it is not to be 😞 |
|
Ah.I have to fix this failure, to |
|
Eh! It's actually a bug! We are running helm tests against LATEST images from ghcr.io, not the ones from latest sources! Fix is coming! |
There was a bug in our CI - Kubernetes tests were executed running lates ghcr.io image, rather than the image built from sources of the current PR. This PR fixes it by correctly using the PR commit as tag of the image used as base image for kubernetes tests. (cherry picked from commit 4796675)
When k8s virtualenv is prepared to run k8s tests we are using constraints, this however might lead to a problem when we increase minimum version of an affected dependency and it conflicts with the constraints stored in main. Therefore in case we run tests in CI (which is indicated by specific pull tag that we use) we do not use constraints for installing the kubernetes venv. It should be fine, as we are pretty much running this only as a vehicle to run tests. (cherry picked from commit e3d7e68)
There are some clarifications about using the authentication via FlaskAppBuilder - the change implements minimum version of the FAB to 3.3.2 and clarifies the dependencies used in FAB 3 series to be only authlib rather than flask-oauth. Fixes: apache#16944 (this is the second, proper fix this time). Depends on: apache#17290, apache#17289 - those two errors have been detected while analysing failures in this build.
potiuk
force-pushed
the
update-flask-appbuilder-to-3.3.2
branch
from
12a2311
to
84ff29b
Compare
This was referenced Jul 28, 2021
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 2, 2021
There are some clarifications about using the authentication via FlaskAppBuilder - the change implements minimum version of the FAB to 3.3.2 and clarifies the dependencies used in FAB 3 series to be only authlib rather than flask-oauth. Fixes: apache#16944 (this is the second, proper fix this time). (cherry picked from commit 6d7fa87)
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 5, 2021
There are some clarifications about using the authentication via FlaskAppBuilder - the change implements minimum version of the FAB to 3.3.2 and clarifies the dependencies used in FAB 3 series to be only authlib rather than flask-oauth. Fixes: apache#16944 (this is the second, proper fix this time). (cherry picked from commit 6d7fa87)
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
There are some clarifications about using the authentication via FlaskAppBuilder - the change implements minimum version of the FAB to 3.3.2 and clarifies the dependencies used in FAB 3 series to be only authlib rather than flask-oauth. Fixes: #16944 (this is the second, proper fix this time). (cherry picked from commit 6d7fa87)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 17, 2021
There are some clarifications about using the authentication via FlaskAppBuilder - the change implements minimum version of the FAB to 3.3.2 and clarifies the dependencies used in FAB 3 series to be only authlib rather than flask-oauth. Fixes: #16944 (this is the second, proper fix this time). (cherry picked from commit 6d7fa87)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some clarifications about using the authentication
via FlaskAppBuilder - the change implements minimum version of the
FAB to 3.3.2 and clarifies the dependencies used in FAB 3 series
to be only authlib rather than flask-oauth.
Fixes: #16944 (this is the second, proper fix this time).
Depends on: #17290, #17289 - those two errors have been detected while
analysing failures in this build.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.