Do not use constraints when preparing venv for k8s tests on CI #17290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When k8s virtualenv is prepared to run k8s tests we are using constraints, this however might lead to a problem when we increase minimum version of an affected dependency and it conflicts with the constraints stored in main. Therefore in case we run tests in CI (which is indicated by specific pull tag that we use) we do not use constraints for installing the kubernetes venv. It should be fine, as we are pretty much running this only as a vehicle to run tests.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jul 28, 2021
There are some clarifications about using the authentication via FlaskAppBuilder - the change implements minimum version of the FAB to 3.3.2 and clarifies the dependencies used in FAB 3 series to be only authlib rather than flask-oauth. Fixes: apache#16944 (this is the second, proper fix this time). Depends on: apache#17290, apache#17289 - those two errors have been detected while analysing failures in this build.
|
Testing also in #17208 (ti was detected there) |
jedcunningham
approved these changes
Jul 28, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 2, 2021
…e#17290) When k8s virtualenv is prepared to run k8s tests we are using constraints, this however might lead to a problem when we increase minimum version of an affected dependency and it conflicts with the constraints stored in main. Therefore in case we run tests in CI (which is indicated by specific pull tag that we use) we do not use constraints for installing the kubernetes venv. It should be fine, as we are pretty much running this only as a vehicle to run tests. (cherry picked from commit 96bd4a1)
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
When k8s virtualenv is prepared to run k8s tests we are using constraints, this however might lead to a problem when we increase minimum version of an affected dependency and it conflicts with the constraints stored in main. Therefore in case we run tests in CI (which is indicated by specific pull tag that we use) we do not use constraints for installing the kubernetes venv. It should be fine, as we are pretty much running this only as a vehicle to run tests. (cherry picked from commit 96bd4a1)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 17, 2021
When k8s virtualenv is prepared to run k8s tests we are using constraints, this however might lead to a problem when we increase minimum version of an affected dependency and it conflicts with the constraints stored in main. Therefore in case we run tests in CI (which is indicated by specific pull tag that we use) we do not use constraints for installing the kubernetes venv. It should be fine, as we are pretty much running this only as a vehicle to run tests. (cherry picked from commit 96bd4a1)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Dec 3, 2021
This was failing with following: ``` /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/scripts/ci/kubernetes/ci_run_kubernetes_tests.sh: line 102: constraints[@]: unbound variable Exporting logs for cluster "airflow-python-3.7-v1.20.2" to: /tmp/kind_logs_2021-12-03_0_0 ``` and was caused by apache#17290
kaxil
added a commit
that referenced
this pull request
Dec 3, 2021
This was failing with the following: ``` /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/scripts/ci/kubernetes/ci_run_kubernetes_tests.sh: line 102: constraints[@]: unbound variable Exporting logs for cluster "airflow-python-3.7-v1.20.2" to: /tmp/kind_logs_2021-12-03_0_0 ``` and was caused by #17290
potiuk
pushed a commit
that referenced
this pull request
Jan 22, 2022
This was failing with the following: ``` /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/scripts/ci/kubernetes/ci_run_kubernetes_tests.sh: line 102: constraints[@]: unbound variable Exporting logs for cluster "airflow-python-3.7-v1.20.2" to: /tmp/kind_logs_2021-12-03_0_0 ``` and was caused by #17290 (cherry picked from commit 0afed43)
jedcunningham
pushed a commit
that referenced
this pull request
Jan 27, 2022
This was failing with the following: ``` /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/scripts/ci/kubernetes/ci_run_kubernetes_tests.sh: line 102: constraints[@]: unbound variable Exporting logs for cluster "airflow-python-3.7-v1.20.2" to: /tmp/kind_logs_2021-12-03_0_0 ``` and was caused by #17290 (cherry picked from commit 0afed43)
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 4, 2022
This was failing with the following: ``` /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/scripts/ci/kubernetes/ci_run_kubernetes_tests.sh: line 102: constraints[@]: unbound variable Exporting logs for cluster "airflow-python-3.7-v1.20.2" to: /tmp/kind_logs_2021-12-03_0_0 ``` and was caused by apache/airflow#17290 (cherry picked from commit 0afed43a8afde093277be2862138cb32fba8ed29) GitOrigin-RevId: 85cce0769460829865c5f374809607ad922de715
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 10, 2022
This was failing with the following: ``` /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/scripts/ci/kubernetes/ci_run_kubernetes_tests.sh: line 102: constraints[@]: unbound variable Exporting logs for cluster "airflow-python-3.7-v1.20.2" to: /tmp/kind_logs_2021-12-03_0_0 ``` and was caused by apache/airflow#17290 GitOrigin-RevId: 0afed43a8afde093277be2862138cb32fba8ed29
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Aug 27, 2022
This was failing with the following: ``` /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/scripts/ci/kubernetes/ci_run_kubernetes_tests.sh: line 102: constraints[@]: unbound variable Exporting logs for cluster "airflow-python-3.7-v1.20.2" to: /tmp/kind_logs_2021-12-03_0_0 ``` and was caused by apache/airflow#17290 GitOrigin-RevId: 0afed43a8afde093277be2862138cb32fba8ed29
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 4, 2022
This was failing with the following: ``` /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/scripts/ci/kubernetes/ci_run_kubernetes_tests.sh: line 102: constraints[@]: unbound variable Exporting logs for cluster "airflow-python-3.7-v1.20.2" to: /tmp/kind_logs_2021-12-03_0_0 ``` and was caused by apache/airflow#17290 GitOrigin-RevId: 0afed43a8afde093277be2862138cb32fba8ed29
aglipska
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 7, 2022
This was failing with the following: ``` /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/scripts/ci/kubernetes/ci_run_kubernetes_tests.sh: line 102: constraints[@]: unbound variable Exporting logs for cluster "airflow-python-3.7-v1.20.2" to: /tmp/kind_logs_2021-12-03_0_0 ``` and was caused by apache/airflow#17290 GitOrigin-RevId: 0afed43a8afde093277be2862138cb32fba8ed29
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Dec 7, 2022
This was failing with the following: ``` /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/scripts/ci/kubernetes/ci_run_kubernetes_tests.sh: line 102: constraints[@]: unbound variable Exporting logs for cluster "airflow-python-3.7-v1.20.2" to: /tmp/kind_logs_2021-12-03_0_0 ``` and was caused by apache/airflow#17290 GitOrigin-RevId: 0afed43a8afde093277be2862138cb32fba8ed29
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jan 27, 2023
This was failing with the following: ``` /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/scripts/ci/kubernetes/ci_run_kubernetes_tests.sh: line 102: constraints[@]: unbound variable Exporting logs for cluster "airflow-python-3.7-v1.20.2" to: /tmp/kind_logs_2021-12-03_0_0 ``` and was caused by apache/airflow#17290 GitOrigin-RevId: 0afed43a8afde093277be2862138cb32fba8ed29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When k8s virtualenv is prepared to run k8s tests we are using
constraints, this however might lead to a problem when we increase
minimum version of an affected dependency and it conflicts with
the constraints stored in main.
Therefore in case we run tests in CI (which is indicated by
specific pull tag that we use) we do not use constraints for
installing the kubernetes venv. It should be fine, as we are
pretty much running this only as a vehicle to run tests.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.