Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot edit custom fields on provider connections #20839

Closed
2 tasks done
mike-mcdonald opened this issue Jan 13, 2022 · 1 comment · Fixed by #20883
Closed
2 tasks done

Cannot edit custom fields on provider connections #20839

mike-mcdonald opened this issue Jan 13, 2022 · 1 comment · Fixed by #20883
Labels
area:core kind:bug This is a clearly a bug

Comments

@mike-mcdonald
Copy link
Contributor

Apache Airflow version

2.2.3 (latest released)

What happened

Connections from providers are not saving edited values in any custom connection forms. You can work around the issue by changing connection type to something like HTTP, and modifying the extra field's JSON.

What you expected to happen

No response

How to reproduce

Using the official docker compose deployment, add a new connection of type 'Azure Data Explorer' and fill out one of the custom connection fields (e.g., "Tenant ID"). Save the record. Edit the record and enter a new value for the same field or any other field that is defined in the associated Hook's get_connection_form_widgets function. Save the record. Edit again. The changes were not saved.

Operating System

Windows 10, using docker

Versions of Apache Airflow Providers

No response

Deployment

Docker-Compose

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@mike-mcdonald mike-mcdonald added area:core kind:bug This is a clearly a bug labels Jan 13, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 13, 2022

Thanks for opening your first issue here! Be sure to follow the issue template!

mike-mcdonald added a commit to mike-mcdonald/airflow that referenced this issue Jan 21, 2022
Fixes issue where custom connectionfields are not updated because `extra` field is in form and has previous values, overriding custom field values.
Adds portion of connection form tests to test functionality.

Ref: apache#20839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core kind:bug This is a clearly a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant