Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy button on a Dag run's config copies only one run config #36848

Closed
1 of 2 tasks
anteverse opened this issue Jan 17, 2024 · 4 comments · Fixed by #36855
Closed
1 of 2 tasks

Copy button on a Dag run's config copies only one run config #36848

anteverse opened this issue Jan 17, 2024 · 4 comments · Fixed by #36855
Labels
affected_version:2.8 Issues Reported for 2.8 area:UI Related to UI/UX. For Frontend Developers. good first issue kind:bug This is a clearly a bug

Comments

@anteverse
Copy link
Contributor

anteverse commented Jan 17, 2024

Apache Airflow version

2.8.0

If "Other Airflow 2 version" selected, which one?

No response

What happened?

Hi, I believe I hit a case where the run config that's exported when we click "Copy" does not seem to be updated when we switch from one run to another in the UI.
The copied json of the run config is always the same.

What you think should happen instead?

I believe the content of the copy should match the right run, and be updated as we switch runs.

Little bit of a clue: being on one run view, if I refresh the page, then I can copy the right json.

How to reproduce

Have this DAG for instance:

with DAG(
    dag_id="issue_copy_button",
    schedule=None,
    catchup=False,
    start_date=pendulum.today("UTC").add(days=-1),
    params={
        "list_of_strings": Param(
            [],
            type="array",
            title="List of strings",
            items={"type": "string"},
        ),
    },
) as dag:

    @task
    def my_task() -> None:
        print("Task done")

    my_task()

Now in the UI:

  1. trigger a first run with: ["a", "b", "c"] then a second run with ["d", "e", "f"].
  2. open the last run. Press "Copy" on the run config. You get the json of the set of values for this run, hence {"list_of_strings": ["d", "e", "f"]}
  3. now open the other run (on the left panel). Press "Copy" on the run config. You will still get the same json as before, hence {"list_of_strings": ["d", "e", "f"]} instead of {"list_of_strings": ["a", "b", "c"]} which matches the currently opened run.

Tested in 2.8.0 and 2.7.3.

Let me know you need more details or if there's anything I should do differently. I could not find a matching existing issue, but feel free to close if there's one.

Thank you!

Screenshot 2024-01-17 at 17 20 14

Operating System

Airflow on Kubernetes

Versions of Apache Airflow Providers

No response

Deployment

Official Apache Airflow Helm Chart

Deployment details

No response

Anything else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@anteverse anteverse added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Jan 17, 2024
Copy link

boring-cyborg bot commented Jan 17, 2024

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@Taragolis
Copy link
Contributor

I guess it similar to #34846 and might be even fixed by #34904

@Taragolis
Copy link
Contributor

Well nope, it still persists in current main

@Taragolis Taragolis added good first issue area:UI Related to UI/UX. For Frontend Developers. and removed area:core needs-triage label for new issues that we didn't triage yet labels Jan 17, 2024
@eladkal eladkal added the affected_version:2.8 Issues Reported for 2.8 label Jan 17, 2024
@anteverse
Copy link
Contributor Author

Thanks a lot, looking forward to the next releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected_version:2.8 Issues Reported for 2.8 area:UI Related to UI/UX. For Frontend Developers. good first issue kind:bug This is a clearly a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants