Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task id copy button copying wrong id #34904

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

Adaverse
Copy link
Contributor

Fixes: #34846
Sets the value that needs to be copied whenever it changes. The previous implementation had a bug since the component will only render once with the page.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Oct 12, 2023
@eladkal eladkal added this to the Airflow 2.7.3 milestone Oct 13, 2023
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Oct 13, 2023
@eladkal eladkal changed the title Fixes copy bug Fix task id copy button copying wrong id Oct 13, 2023
Copy link
Contributor

@Taragolis Taragolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked locally this patch and it works

@bbovenzi bbovenzi merged commit 3a48d0c into apache:main Jan 16, 2024
44 checks passed
jedcunningham pushed a commit that referenced this pull request Feb 9, 2024
Co-authored-by: adaverse <adaverse@Akash>
(cherry picked from commit 3a48d0c)
ephraimbuddy pushed a commit that referenced this pull request Feb 22, 2024
Co-authored-by: adaverse <adaverse@Akash>
(cherry picked from commit 3a48d0c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task ID copy button copying wrong ID
6 participants