Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airflow changes permissions of home directory #38137

Closed
1 of 2 tasks
BretaGlac opened this issue Mar 14, 2024 · 1 comment · Fixed by #38164
Closed
1 of 2 tasks

Airflow changes permissions of home directory #38137

BretaGlac opened this issue Mar 14, 2024 · 1 comment · Fixed by #38164
Assignees
Labels
affected_version:2.8 Issues Reported for 2.8 area:core kind:bug This is a clearly a bug

Comments

@BretaGlac
Copy link

Apache Airflow version

2.8.2

If "Other Airflow 2 version" selected, which one?

No response

What happened?

AIrflow changes permissions of home directory with every Dag run. It is caused by #37310 . This causes issues with using ssh keys.

What you think should happen instead?

Airflow should stop changing permissions for parent folders before it reaches home directory.

How to reproduce

TRigger a dag

Operating System

Red Hat Enterprise Linux 8.9

Versions of Apache Airflow Providers

No response

Deployment

Virtualenv installation

Deployment details

No response

Anything else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@BretaGlac BretaGlac added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Mar 14, 2024
Copy link

boring-cyborg bot commented Mar 14, 2024

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@Taragolis Taragolis added affected_version:2.8 Issues Reported for 2.8 and removed needs-triage label for new issues that we didn't triage yet labels Mar 14, 2024
@potiuk potiuk self-assigned this Mar 14, 2024
potiuk added a commit to potiuk/airflow that referenced this issue Mar 18, 2024
When log dir permission was changed by log handler, we've
implemented also changing permissions of parent folders recursively,
however it was quite a bit too much to change it for home directory
where the log folder could have been created - because in some cases
changing permissions might lead to unexpected side-effects - such
as loosing ability to login to ssh server.

Fixes: apache#38137
potiuk added a commit that referenced this issue Mar 18, 2024
When log dir permission was changed by log handler, we've
implemented also changing permissions of parent folders recursively,
however it was quite a bit too much to change it for home directory
where the log folder could have been created - because in some cases
changing permissions might lead to unexpected side-effects - such
as loosing ability to login to ssh server.

Fixes: #38137
jedcunningham pushed a commit that referenced this issue Mar 18, 2024
When log dir permission was changed by log handler, we've
implemented also changing permissions of parent folders recursively,
however it was quite a bit too much to change it for home directory
where the log folder could have been created - because in some cases
changing permissions might lead to unexpected side-effects - such
as loosing ability to login to ssh server.

Fixes: #38137
(cherry picked from commit 2c1d0f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected_version:2.8 Issues Reported for 2.8 area:core kind:bug This is a clearly a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants