Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on_kill method to BigQueryInsertJobOperator #10866

Merged
merged 2 commits into from Sep 11, 2020
Merged

Add on_kill method to BigQueryInsertJobOperator #10866

merged 2 commits into from Sep 11, 2020

Conversation

ghost
Copy link

@ghost ghost commented Sep 10, 2020

Class BigQueryInsertJobOperator in package airflow.providers.google.cloud.operators.dataproc has now on_kill method.

Tests:
Class TestBigQueryInsertJobOperator in package tests.providers.google.cloud.operators.test_bigquery has now test_on_kill.

This issue is very similar to #10847


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Sep 10, 2020
@turbaszek
Copy link
Member

@tszerszen can you please take a look at CI? We hit the magic number of allowed arguments and we need to add pylint: disable=too-many-arguments

@ghost
Copy link
Author

ghost commented Sep 11, 2020

@tszerszen can you please take a look at CI? We hit the magic number of allowed arguments and we need to add pylint: disable=too-many-arguments

Done in commit BigQueryInsertJobOperator pylint disable=too-many-arguments

@turbaszek turbaszek merged commit 41a6273 into apache:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants