Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add azure files to gcs transfer operator #10991

Conversation

FHoffmannCode
Copy link
Contributor


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added provider:microsoft-azure Azure-related issues provider:google Google (including GCP) related issues labels Sep 17, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 17, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://apache-airflow-slack.herokuapp.com/

@FHoffmannCode
Copy link
Contributor Author

@turbaszek

@michalslowikowski00
Copy link
Contributor

michalslowikowski00 commented Sep 17, 2020

@FHoffmannCode FHoffmannCode force-pushed the add-azure-files-to-gcs-transfer-operator branch from 4d3ddfe to f582a73 Compare September 25, 2020 10:42
Copy link
Contributor

@olchas olchas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue in docstring, but LGTM overall.

@FHoffmannCode FHoffmannCode force-pushed the add-azure-files-to-gcs-transfer-operator branch 2 times, most recently from 1d9d0e6 to 4ed1b66 Compare September 25, 2020 12:47
@michalslowikowski00
Copy link
Contributor

LGTM.
Great job. :)

@FHoffmannCode FHoffmannCode force-pushed the add-azure-files-to-gcs-transfer-operator branch from 3658506 to 282e2b7 Compare September 30, 2020 13:31
@FHoffmannCode FHoffmannCode force-pushed the add-azure-files-to-gcs-transfer-operator branch from 282e2b7 to fea7f79 Compare October 1, 2020 08:22
@FHoffmannCode FHoffmannCode force-pushed the add-azure-files-to-gcs-transfer-operator branch 2 times, most recently from d868e0e to 1f0b8be Compare October 2, 2020 08:11
@FHoffmannCode FHoffmannCode force-pushed the add-azure-files-to-gcs-transfer-operator branch from 1f0b8be to cbcb490 Compare October 5, 2020 07:41
@github-actions
Copy link

github-actions bot commented Oct 5, 2020

The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow,
that you will not see in the list of checks (you will see "Wait for images" jobs instead).

You can checks the status of those images in The workflow run

@github-actions
Copy link

github-actions bot commented Oct 5, 2020

The Build Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

github-actions bot commented Oct 5, 2020

The Build Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@FHoffmannCode FHoffmannCode force-pushed the add-azure-files-to-gcs-transfer-operator branch 2 times, most recently from e05c22b to 697f32a Compare October 6, 2020 13:14
@github-actions
Copy link

github-actions bot commented Oct 6, 2020

The Build Workflow run is cancelling this PR. The job has been cancelled by another workflow.

@FHoffmannCode FHoffmannCode force-pushed the add-azure-files-to-gcs-transfer-operator branch from 697f32a to fab668b Compare October 7, 2020 07:14
@turbaszek turbaszek merged commit b0fcf67 into apache:master Oct 7, 2020
@turbaszek turbaszek deleted the add-azure-files-to-gcs-transfer-operator branch October 7, 2020 09:08
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 7, 2020

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues provider:microsoft-azure Azure-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants