-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add azure files to gcs transfer operator #10991
add azure files to gcs transfer operator #10991
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
@FHoffmannCode are you going to add example dag? :) |
airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py
Outdated
Show resolved
Hide resolved
airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py
Outdated
Show resolved
Hide resolved
airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py
Outdated
Show resolved
Hide resolved
airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py
Outdated
Show resolved
Hide resolved
airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py
Outdated
Show resolved
Hide resolved
airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py
Outdated
Show resolved
Hide resolved
4d3ddfe
to
f582a73
Compare
airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor issue in docstring, but LGTM overall.
airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py
Outdated
Show resolved
Hide resolved
airflow/providers/microsoft/azure/example_dags/example_azure_fileshare_to_gcs.py
Outdated
Show resolved
Hide resolved
airflow/providers/microsoft/azure/example_dags/example_azure_fileshare_to_gcs.py
Outdated
Show resolved
Hide resolved
1d9d0e6
to
4ed1b66
Compare
LGTM. |
airflow/providers/google/cloud/example_dags/example_azure_fileshare_to_gcs.py
Outdated
Show resolved
Hide resolved
airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py
Outdated
Show resolved
Hide resolved
airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py
Outdated
Show resolved
Hide resolved
airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py
Outdated
Show resolved
Hide resolved
3658506
to
282e2b7
Compare
282e2b7
to
fea7f79
Compare
airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py
Outdated
Show resolved
Hide resolved
d868e0e
to
1f0b8be
Compare
1f0b8be
to
cbcb490
Compare
The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow, You can checks the status of those images in The workflow run |
The Build Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
The Build Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
e05c22b
to
697f32a
Compare
The Build Workflow run is cancelling this PR. The job has been cancelled by another workflow. |
697f32a
to
fab668b
Compare
Awesome work, congrats on your first merged pull request! |
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.