Commits on Oct 6, 2020

1. Prevent race condition in trying to collect result from DagFileProcessor …

   A rare race condition was noticed in the Scheduler HA PR where the
   "test_dags_with_system_exit" test would occasionally fail with the
   following symptoms:
   
   - The pipe was "readable" as returned by
     `multiprocessing.connection.wait`
   - On reading it yielded an EOFError, meaning the other side had closed
     the connection
   - But the process was still alive/running
   
   This previously would result in the Manager process dying with an error.
   
   This PR makes a few changes:
   
   - It ensures that the pipe is simplex, not duplex (we only ever send one
     data) as this is simpler
   - We ensure that the "other" end of the pipe is correctly closed in both
     parent and child processes. Without this the pipe would be kept open
     (sometimes) until the child process had closed anyway.
   - When we get an EOFError on reading and the process is still alive, we
     give it a few seconds to shut down cleanly, and then kill it.

   

   ashb committed Oct 6, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for afc2d47
   • Browse repository at this point

   Copy the full SHA

   afc2d47 View commit details

   Browse the repository at this point in the history