Return nonzero exit codes on pool import errors.

[jmcarp]

The pool import command returns an exit code of zero in a few different
error cases. This causes problems for scripts that invoke the command,
since commands that actually failed will appear to have worked. This
patch returns a nonzero code if the pool file doesn't exist, if the file
isn't valid json, or if any of the pools in the file is invalid.

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!

[turbaszek]

Should we use f-strings?

[turbaszek]

Suggested change

	return pools, failed # pylint: disable=lost-exception
	return pools, failed

Should we be able to remove it?

[jmcarp]

Thanks for reviewing @turbaszek, I updated the branch.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[jmcarp]

@kaxil @turbaszek is it all right that some "quarantined" tests are failing? I don't think they're related to these changes.

[potiuk]

@jmcarp Some of the quarantined tests started to fail recently and we have an on-going effort to fix them before 2.0 is out. See the automated issue here: #10118 and Quarantine Issues that are occasionally failing and are quarantined

BTW. If you would like to help with that - feel free to pick any of those issues :).

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[jmcarp]

Not sure what changed, but I rebased on master, and tests are passing now. Is this ok to merge?

[ashb]

Suggested change

	print("Failed to update pool(s): {}".format(", ".join(failed)))
	sys.exit(1)
	exit("Failed to update pool(s): {}".format(", ".join(failed)))

This way the error goes to stderr, not stdout

[jmcarp]

I see that we use a mixture of sys.exit and raise SystemExit across the cli module. Do we prefer one or the other?

[jmcarp]

I picked sys.exit arbitrarily for now. We can pick one invocation and use it consistently throughout the module separately.

[ashb]

One small change please

[github-actions]

The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!