-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - TestSchedulerJobQueriesCount::test_process_dags_queries_count #12273
Conversation
Will do |
The tests were passing on #11335 |
@kaxil I am afraid that this test may not start for some reason. I tested locally and I have a message that this attribute is missing. It have been deleted. See: https://github.com/apache/airflow/pull/11335/files#diff-230a06cebe53507c57e3076e4651050de7b8e741212f304acc516a338fce3332L347-L349 |
Got it, yes, right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix the other tests where config is still there
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it! |
I checked the log for those tests on CI and these tests are now green.
|
The first time this test was broken in the following commit.
406ed29 Make Dag Serialization a hard requirement (#11335)
And the number of database queries has changed: Fortunately, it was optimization.
92e405e Call scheduler "book-keeping" operations less frequently. (#12139)
A few more tests look like they might be broken too:
airflow/tests/jobs/test_scheduler_job.py
Line 1742 in 92e405e
airflow/tests/jobs/test_scheduler_job.py
Line 3712 in 92e405e
Thanks to @potiuk for creating the quarantine test list. This allowed me to see that the tests that had previously been only partially unstable. Now it was never successful.
#10118
CC: @ashb @kaxil
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.