Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test - TestImpersonation #12274

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Nov 11, 2020

That test failed, and now I have the green "PASSED" text.

tests/core/test_impersonation_tests.py::TestImpersonationWithCustomPythonPath::test_impersonation_custom PASSED                                                                                      [100%]

===================================================================================== 1 passed, 4 deselected in 44.23s =====================================================================================

Thanks to @potiuk for creating the quarantine test list. This allowed me to see that the tests that had previously been only partially unstable. Now it was never successful.
#10118


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move it out of quarantine then ?

@mik-laj
Copy link
Member Author

mik-laj commented Nov 11, 2020

Should we move it out of quarantine then ?

I don't know if this test is stable or not. For now, I would like it to continue to monitor its stability continues. I couldn't do that if this test didn't work. In next PR, I can try to fix it, but I need more information about its condition.

@potiuk
Copy link
Member

potiuk commented Nov 11, 2020

I don't know if this test is stable or not. For now, I would like it to continue to monitor its stability continues. I couldn't do that if this test didn't work. In next PR, I can try to fix it, but I need more information about its condition.

Works for me :)

@potiuk potiuk merged commit 6b5640d into apache:master Nov 11, 2020
@potiuk potiuk deleted the test-impersonation branch November 11, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants