Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about webserver_config.py #13155

Merged
merged 1 commit into from
Dec 20, 2020
Merged

Conversation

AmarEL
Copy link
Contributor

@AmarEL AmarEL commented Dec 18, 2020

A quick reference about how to configure other authentication methods
closes: #12827

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 18, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

rbac = True

The default authentication option is the AUTH_DB, and a new user can be created through a CLI command or by the
UI modifying the ``$AIRFLOW_HOME/webserver_config.py`` with the following options:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the impression that this sentence is not completely correct. Why should the user edit this file? To add a new user?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit this file as the code example I wrote will allow user self registration.
I will edit this section to make it clear

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@AmarEL AmarEL force-pushed the master branch 2 times, most recently from efce00d to 395d7ad Compare December 19, 2020 20:51
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 20, 2020
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@mik-laj mik-laj merged commit 81fed80 into apache:master Dec 20, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 20, 2020

Awesome work, congrats on your first merged pull request!

kaxil pushed a commit that referenced this pull request Jan 21, 2021
Co-authored-by: Andre Amaral <aamaral@bionexo.com>
(cherry picked from commit 81fed80)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge kind:documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing docs about webserver_config.py
2 participants