Fix disable login option behavior #13191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:webserver
AmarEL
force-pushed
the
fix-disable-login-option
branch
from
3406328
to
6b87065
Compare
|
@AmarEL Could you please add tests to prevent regressions and documentation on how to disable log-in? |
AmarEL
force-pushed
the
fix-disable-login-option
branch
4 times, most recently
from
573b804
to
6fffb2d
Compare
…ting the process to do it
AmarEL
force-pushed
the
fix-disable-login-option
branch
from
6fffb2d
to
8af934f
Compare
|
mik-laj
approved these changes
Dec 28, 2020
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When set the AUTH_ROLE_PUBLIC entry in the webserver_config.py, the app needs to be able to read the value for this entry and this pull request fix the way to access this entry value
closes: #13142
closes: #8815