Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifies differences between extras and provider packages #13810

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 21, 2021


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk potiuk force-pushed the clarification-of-extras-vs-packages branch from e914891 to ba150e6 Compare January 21, 2021 11:29
Copy link
Contributor

@noelmcloughlin noelmcloughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor comments.

docs/apache-airflow/extra-packages-ref.rst Outdated Show resolved Hide resolved
docs/apache-airflow/extra-packages-ref.rst Show resolved Hide resolved
Copy link
Contributor

@noelmcloughlin noelmcloughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!! @potiuk

@potiuk
Copy link
Member Author

potiuk commented Jan 21, 2021

LGTM. thanks!! @potiuk

Thanks for cooperation! If you see any more corrections needed to the docs or elsewhere - feel free to create PRs on your own - happy to review and merge it :).

@potiuk potiuk force-pushed the clarification-of-extras-vs-packages branch 2 times, most recently from b8148c3 to c0f02dd Compare January 22, 2021 18:01
Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nits

docs/apache-airflow/upgrading-to-2.rst Show resolved Hide resolved
docs/apache-airflow/upgrading-to-2.rst Show resolved Hide resolved
docs/apache-airflow/installation.rst Show resolved Hide resolved
@potiuk potiuk force-pushed the clarification-of-extras-vs-packages branch from c0f02dd to 1943664 Compare January 23, 2021 15:13
@github-actions
Copy link

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

@potiuk potiuk force-pushed the clarification-of-extras-vs-packages branch from 1943664 to ca782d9 Compare January 23, 2021 17:04
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jan 25, 2021
@github-actions
Copy link

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit dbd0262 into apache:master Jan 25, 2021
@potiuk potiuk deleted the clarification-of-extras-vs-packages branch January 25, 2021 21:13
kaxil pushed a commit that referenced this pull request Jan 27, 2021
kaxil pushed a commit that referenced this pull request Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants