Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of repeated constant in AirflowConfigParser #14023

Merged

Conversation

ashb
Copy link
Member

@ashb ashb commented Feb 2, 2021

Small refactor that doesn't change any functionality, but does make
future testing/refactoring easier.

Small refactor that doesn't change any functionality, but does make
future testing/refactoring easier.
@ashb ashb added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Feb 2, 2021
@ashb ashb added this to the Airflow 2.1 milestone Feb 2, 2021
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Feb 2, 2021
@github-actions
Copy link

github-actions bot commented Feb 2, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@ashb ashb merged commit d65376c into apache:master Feb 2, 2021
@ashb ashb deleted the configparser-remove-duplicated-env-name branch February 2, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants