Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default worker_refresh_interval to 6000 seconds #14970

Merged

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Mar 24, 2021

The default value for [webserver] worker_refresh_interval was 30 seconds for
Airflow <=2.0.1. However, since Airflow 2.0 DAG Serialization is a hard requirement
and the Webserver used the serialized DAGs, there is no need to kill an existing
worker and create a new one as frequently as 30 seconds.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

The default value for `[webserver] worker_refresh_interval` was `30` seconds for
Airflow <=2.0.1. However, since Airflow 2.0 DAG Serialization is a hard requirement
and the Webserver used the serialized DAGs, there is no need to kill an existing
worker and create a new one as frequently as `30` seconds.
@kaxil kaxil requested a review from ashb March 24, 2021 01:34
@kaxil kaxil modified the milestones: Airflow 2.0.2, Airflow 2.1 Mar 24, 2021
### Default `[webserver] worker_refresh_interval` is changed to `6000` seconds

The default value for `[webserver] worker_refresh_interval` was `30` seconds for
Airflow <=2.0.1. However, since Airflow 2.0 DAG Serialization is a hard requirement
Copy link
Member Author

@kaxil kaxil Mar 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in 2.0.2 (or 2.1) as it is not a bugfix but a good optimization?

This wouldn't affect the current deployment that have [webserver] worker_refresh_interval set in their airflow.cfg but affects new deployments and existing deployments that don't have it in airflow.cfg and rely on the default fallback

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 24, 2021
@kaxil kaxil merged commit 85760cf into apache:master Mar 24, 2021
@kaxil kaxil deleted the update-default-worker-refresh-interval branch March 24, 2021 12:31
@kaxil kaxil modified the milestones: Airflow 2.1, Airflow 2.0.2 Mar 25, 2021
@ashb ashb modified the milestones: Airflow 2.0.2, Airflow 2.1 Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants