Parse Error 410 in kubernetes Watcher and return latest resource version #15418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
requested review from
ashb,
kaxil,
turbaszek and
XD-DENG
as code owners
boring-cyborg
bot
added
provider:cncf-kubernetes
ephraimbuddy
force-pushed
the
parse-watcher-stream-error
branch
2 times, most recently
from
4a96c1b
to
c62fe11
Compare
Currently, when kubernetes watcher stream encounters Error 410('too old resource version'),
it returns resource version '0' which is not the latest version.
This 410 error contains the latest resource version in its message.
This PR parses the message and return the latest resource version so that
watcher can continue watching instead of returning '0'
ephraimbuddy
force-pushed
the
parse-watcher-stream-error
branch
from
c62fe11
to
cc8ae27
Compare
|
@ephraimbuddy is there a case where we would get a 410 for a different reason? I feel hesitant to exactly parse an error in case the k8s folks change the wording. |
Hi @dimberman , it's now being addressed here: #15500. The PR will close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when kubernetes watcher stream encounter Error 410('too old resource version'),
it returns resource version '0' which is not the latest version.
This 410 error contains the latest resource version in its message.
This PR parses the message and return the latest resource version so that
watcher can continue watching instead of dieing
Some relevant links on this:
kubernetes-client/python#609
kubernetes-client/python#728 (comment)
This would likely fix some issues #14175, #13916, and #12644 (comment)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.