Clean up the pre-commit config #15703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
May 6, 2021
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 6, 2021
This reverts commit 803850a.
potiuk
added a commit
that referenced
this pull request
May 6, 2021
|
Hey @jbampton. I had to revert this change because we had problem in master. Can you please re-do it but also add ".pre-commit-config.yaml" to the list of files here: airflow/scripts/ci/selective_ci_checks.sh Line 495 in c61af5c And fix all the problems that it will uncover ? We are running selective checks, trying to run minimal set of tests with some "small" changes, but seems that in case just ".pre-commit.yaml" was modified only sub-set of pre-commits were run and the change introduced some failures. When you add the config file to the "important files" list, it will trigger all tests in your PR and you will be able to see what you need to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.