Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolution to force dependencies to use patched lodash #15777

Merged
merged 1 commit into from
May 11, 2021

Conversation

ryanahamilton
Copy link
Contributor

Resolves a known vulnerability in lodash. Lodash is an indirect dependency and not all of the the direct dependencies have been patched yet. This resolution forces the currently utilized 4.17.15, 4.17.19, and 4.17.20 versions to use the safe 4.17.21 patch.

@ryanahamilton ryanahamilton requested a review from ashb as a code owner May 11, 2021 16:08
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels May 11, 2021
@ryanahamilton ryanahamilton added security Security issues that must be fixed area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues and removed area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels May 11, 2021
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be best to see update the packages that use lodash but, in the interest of time and to avoid potentially breaking changes, this is a perfectly fine workaround.

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label May 11, 2021
@kaxil kaxil merged commit 74c1ce0 into apache:master May 11, 2021
@kaxil kaxil deleted the lodash_patch branch May 11, 2021 17:05
kaxil pushed a commit to astronomer/airflow that referenced this pull request May 11, 2021
…apache#15777)

Resolves [a known vulnerability](GHSA-35jh-r3h4-6jhm) in lodash. Lodash is an indirect dependency and not all of the the direct dependencies have been patched yet. This resolution forces the currently utilized `4.17.15`, `4.17.19`, and `4.17.20` versions to use the safe `4.17.21` patch.

(cherry picked from commit 74c1ce0)
kaxil pushed a commit to astronomer/airflow that referenced this pull request May 12, 2021
…apache#15777)

Resolves [a known vulnerability](GHSA-35jh-r3h4-6jhm) in lodash. Lodash is an indirect dependency and not all of the the direct dependencies have been patched yet. This resolution forces the currently utilized `4.17.15`, `4.17.19`, and `4.17.20` versions to use the safe `4.17.21` patch.

(cherry picked from commit 74c1ce0)
jhtimmins pushed a commit that referenced this pull request May 12, 2021
…#15777)

Resolves [a known vulnerability](GHSA-35jh-r3h4-6jhm) in lodash. Lodash is an indirect dependency and not all of the the direct dependencies have been patched yet. This resolution forces the currently utilized `4.17.15`, `4.17.19`, and `4.17.20` versions to use the safe `4.17.21` patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests security Security issues that must be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants