Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove class references in changelogs #16454

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jun 15, 2021

PyPI does not handle class references in changelogs.
Since we want changelogs to be part of PyPI readmes,
we need to remove those.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

PyPI does not handle class references in changelogs.
Since we want changelogs to be part of PyPI readmes,
we need to remove those.
@potiuk potiuk requested a review from turbaszek as a code owner June 15, 2021 09:37
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jun 15, 2021
@potiuk potiuk requested review from ashb, kaxil, msumit and eladkal June 15, 2021 09:37
@potiuk
Copy link
Member Author

potiuk commented Jun 15, 2021

BTW. Need to add python -m readme_renderer README.rst as part of the preparation step :)

@uranusjr
Copy link
Member

Does twine check not already do that? https://twine.readthedocs.io/en/latest/#twine-check

@potiuk
Copy link
Member Author

potiuk commented Jun 15, 2021

Does twine check not already do that? https://twine.readthedocs.io/en/latest/#twine-check

It does. but so far we run it as 'last' step already after the doc-change was merged and packages were prepared. But yeah, it could be running twine check as the step in CI/preparation process rather than readme_renderer, to be more complete.

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jun 15, 2021
@potiuk potiuk merged commit 8a9c337 into apache:main Jun 15, 2021
@potiuk potiuk deleted the remove-class-from-docker-provider-changelog branch June 15, 2021 10:58
@potiuk potiuk restored the remove-class-from-docker-provider-changelog branch April 26, 2022 20:47
@potiuk potiuk deleted the remove-class-from-docker-provider-changelog branch July 29, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants