Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pylint error in tests/ #16585

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Fix pylint error in tests/ #16585

merged 1 commit into from
Jun 22, 2021

Conversation

ashb
Copy link
Member

@ashb ashb commented Jun 22, 2021

I'm not sure why this changed/started failing, as we haven't touched this part of the file recently.

Maybe we upgraded pylint recently?


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@ashb
Copy link
Member Author

ashb commented Jun 22, 2021

One thing I did notice that #16553 only took 4 seconds for the in https://github.com/apache/airflow/runs/2875380969?check_suite_focus=true

Mon, 21 Jun 2021 13:08:50 GMT Run pylint for main code.................................................Passed
Mon, 21 Jun 2021 13:11:09 GMT Run pylint for tests.....................................................Passed
Mon, 21 Jun 2021 13:11:15 GMT Run pylint for helm chart tests..........................................Passed

4 seconds seems too quite -- running pylint on tests/ locally takes much longer.

@ashb ashb requested review from potiuk and kaxil June 22, 2021 12:09
@ashb ashb merged commit eeb97cf into apache:main Jun 22, 2021
@ashb ashb deleted the fix-pylint-tests branch June 22, 2021 12:15
Jorricks pushed a commit to Jorricks/airflow that referenced this pull request Jun 24, 2021
I'm not sure why this changed/started failing, as we haven't touched this part of the file recently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants