Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pylint #16682

Merged
merged 1 commit into from Jun 28, 2021
Merged

Remove pylint #16682

merged 1 commit into from Jun 28, 2021

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jun 27, 2021

We've agreed during the voting process that Pylint support
should be disabled: https://lists.apache.org/thread.html/r9e2cc385db8737ec0874ad09872081bd083593ee29e8303e58d21efb%40%3Cdev.airflow.apache.org%3E

This PR:

  • removes all # pylint comments
  • removes pylint pre-commits and related scripts/files
  • removes CI jobs running pylint checks
  • removes documentation about pylint
  • removes unnecessary #noga (adds pre-commit for that)
  • fixes some remaining pydocstyle errors after removing #noqa's

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk
Copy link
Member Author

@potiuk potiuk commented Jun 27, 2021

Anticipating the result of voting - I prepared this PR that removes pylint

@github-actions
Copy link

@github-actions github-actions bot commented Jun 28, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

airflow/api/client/json_client.py Outdated Show resolved Hide resolved
@uranusjr
Copy link
Member

@uranusjr uranusjr commented Jun 28, 2021

We should add a .git-blame-ignore-revs file for this commit.

@uranusjr
Copy link
Member

@uranusjr uranusjr commented Jun 28, 2021

(The changeset is so big GitHub is having trouble rendering, so I’m going to assume this is correct…)

@potiuk
Copy link
Member Author

@potiuk potiuk commented Jun 28, 2021

Indeed. Might be a good point also for few other changes like that. But this has to be a separate PR after we know the commit hash :)

@potiuk
Copy link
Member Author

@potiuk potiuk commented Jun 28, 2021

I've added yesqa to pre-commits and removed all the unnecessary #noqa's. It removed a bit too many of those initially. It does not understand some pydocstyle problems but I figured it will be easier to remove a "public method no doc" error D103 | Missing docstring in public function (which I think is far too much to expect) and fixed remaining small docstyle errors which were earlier ignored by #noqa.

.pre-commit-config.yaml Show resolved Hide resolved
airflow/_vendor/connexion/decorators/parameter.py Outdated Show resolved Hide resolved
We've agreed during the voting process that Pylint support
should be disabled: https://lists.apache.org/thread.html/r9e2cc385db8737ec0874ad09872081bd083593ee29e8303e58d21efb%40%3Cdev.airflow.apache.org%3E

This PR:

* removes all # pylint comments
* removes pylint pre-commits and related scripts/files
* removes CI jobs running pylint checks
* removes documentation about pylint
* removes unnecessary #noga (adds pre-commit for that)
* fixes some remaining pydocstyle errors after removing #noqa's
ashb
ashb approved these changes Jun 28, 2021
kaxil
kaxil approved these changes Jun 28, 2021
Copy link
Member

@kaxil kaxil left a comment

@potiuk potiuk merged commit 866a601 into apache:main Jun 28, 2021
47 of 53 checks passed
@potiuk potiuk deleted the remove-pylint branch Jun 28, 2021
@potiuk
Copy link
Member Author

@potiuk potiuk commented Jun 28, 2021

Booom

jhtimmins added a commit to astronomer/airflow that referenced this issue Jul 8, 2021
We've agreed during the voting process that Pylint support
should be disabled: https://lists.apache.org/thread.html/r9e2cc385db8737ec0874ad09872081bd083593ee29e8303e58d21efb%40%3Cdev.airflow.apache.org%3E

This PR:

* removes all # pylint comments
* removes pylint pre-commits and related scripts/files
* removes CI jobs running pylint checks
* removes documentation about pylint
* removes unnecessary #noga (adds pre-commit for that)
* fixes some remaining pydocstyle errors after removing #noqa's

(cherry picked from commit 866a601)
jhtimmins added a commit that referenced this issue Jul 8, 2021
We've agreed during the voting process that Pylint support
should be disabled: https://lists.apache.org/thread.html/r9e2cc385db8737ec0874ad09872081bd083593ee29e8303e58d21efb%40%3Cdev.airflow.apache.org%3E

This PR:

* removes all # pylint comments
* removes pylint pre-commits and related scripts/files
* removes CI jobs running pylint checks
* removes documentation about pylint
* removes unnecessary #noga (adds pre-commit for that)
* fixes some remaining pydocstyle errors after removing #noqa's

(cherry picked from commit 866a601)
jhtimmins added a commit to astronomer/airflow that referenced this issue Jul 8, 2021
We've agreed during the voting process that Pylint support
should be disabled: https://lists.apache.org/thread.html/r9e2cc385db8737ec0874ad09872081bd083593ee29e8303e58d21efb%40%3Cdev.airflow.apache.org%3E

This PR:

* removes all # pylint comments
* removes pylint pre-commits and related scripts/files
* removes CI jobs running pylint checks
* removes documentation about pylint
* removes unnecessary #noga (adds pre-commit for that)
* fixes some remaining pydocstyle errors after removing #noqa's

(cherry picked from commit 866a601)
jhtimmins added a commit to astronomer/airflow that referenced this issue Jul 9, 2021
We've agreed during the voting process that Pylint support
should be disabled: https://lists.apache.org/thread.html/r9e2cc385db8737ec0874ad09872081bd083593ee29e8303e58d21efb%40%3Cdev.airflow.apache.org%3E

This PR:

* removes all # pylint comments
* removes pylint pre-commits and related scripts/files
* removes CI jobs running pylint checks
* removes documentation about pylint
* removes unnecessary #noga (adds pre-commit for that)
* fixes some remaining pydocstyle errors after removing #noqa's

(cherry picked from commit 866a601)
potiuk added a commit that referenced this issue Jul 9, 2021
We've agreed during the voting process that Pylint support
should be disabled: https://lists.apache.org/thread.html/r9e2cc385db8737ec0874ad09872081bd083593ee29e8303e58d21efb%40%3Cdev.airflow.apache.org%3E

This PR:

* removes all # pylint comments
* removes pylint pre-commits and related scripts/files
* removes CI jobs running pylint checks
* removes documentation about pylint
* removes unnecessary #noga (adds pre-commit for that)
* fixes some remaining pydocstyle errors after removing #noqa's

(cherry picked from commit 866a601)
jhtimmins added a commit to astronomer/airflow that referenced this issue Jul 9, 2021
We've agreed during the voting process that Pylint support
should be disabled: https://lists.apache.org/thread.html/r9e2cc385db8737ec0874ad09872081bd083593ee29e8303e58d21efb%40%3Cdev.airflow.apache.org%3E

This PR:

* removes all # pylint comments
* removes pylint pre-commits and related scripts/files
* removes CI jobs running pylint checks
* removes documentation about pylint
* removes unnecessary #noga (adds pre-commit for that)
* fixes some remaining pydocstyle errors after removing #noqa's

(cherry picked from commit 866a601)
jhtimmins added a commit that referenced this issue Jul 9, 2021
We've agreed during the voting process that Pylint support
should be disabled: https://lists.apache.org/thread.html/r9e2cc385db8737ec0874ad09872081bd083593ee29e8303e58d21efb%40%3Cdev.airflow.apache.org%3E

This PR:

* removes all # pylint comments
* removes pylint pre-commits and related scripts/files
* removes CI jobs running pylint checks
* removes documentation about pylint
* removes unnecessary #noga (adds pre-commit for that)
* fixes some remaining pydocstyle errors after removing #noqa's

(cherry picked from commit 866a601)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants