Disable Helm tests when branch is not main
#17457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are preparing Helm chart from main branch only and we never run it from airflow version branches (similarly as providers) This change disables Helm Chart tests in case default branch is different than main.
potiuk
force-pushed
the
disable-helm-chart-for-other-branches
branch
from
d3d3658
to
74b134e
Compare
potiuk
commented
Aug 6, 2021
| @@ -1118,7 +1123,6 @@ ${{ hashFiles('.pre-commit-config.yaml') }}" | |||
| - tests-mysql | |||
| - tests-mssql | |||
| - tests-postgres | |||
| - tests-kubernetes | |||
There was a problem hiding this comment.
This is not needed - we do not have to wait for kurbernetes tests in order to decide if constraints should be pushed.
jedcunningham
approved these changes
Aug 6, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are preparing Helm chart from
mainbranch only and we neverrun it from airflow version branches (similarly as providers)
This change disables Helm Chart tests in case default branch
is different than main.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.