Install providers from sources in prod image only on main #17458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Random failure only |
|
I'd love to get that it before I start holidays, to test the |
potiuk
force-pushed
the
install-providers-from-sources-prod-only-on-main
branch
from
6a9c5ca
to
d6a7d2c
Compare
potiuk
force-pushed
the
install-providers-from-sources-prod-only-on-main
branch
from
d6a7d2c
to
973e67e
Compare
potiuk
force-pushed
the
install-providers-from-sources-prod-only-on-main
branch
from
973e67e
to
2476b0d
Compare
uranusjr
approved these changes
Aug 7, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
force-pushed
the
install-providers-from-sources-prod-only-on-main
branch
from
2476b0d
to
317213b
Compare
We have a global limit (60 seconds) for individual test execution, however 'test_airflow_context' of the Python Virtualenv test might take longer in case they are run in parallel - because they are using dill serialization including a lot of serializable data from the context of the task. We give the test 120 seconds to complete now.
When we build production image during test in main, we install providers from current sources, to make sure that all the tests including Helm Chart/Kubernetes tests are using latest sources for providers. However, when we build the prod image during v* branches, we want to build the production image using latest released providers instead, because this will be the way it will be built shortly when we release it. We do not run providers test not helm chart tests in this branch so it is more important to build the image in the way it will be built for releases - we run verification then and install dependencies in the very same way it will be done during release.
potiuk
force-pushed
the
install-providers-from-sources-prod-only-on-main
branch
from
317213b
to
a2cbed0
Compare
potiuk
added a commit
that referenced
this pull request
Aug 7, 2021
When we build production image during test in main, we install providers from current sources, to make sure that all the tests including Helm Chart/Kubernetes tests are using latest sources for providers. However, when we build the prod image during v* branches, we want to build the production image using latest released providers instead, because this will be the way it will be built shortly when we release it. We do not run providers test not helm chart tests in this branch so it is more important to build the image in the way it will be built for releases - we run verification then and install dependencies in the very same way it will be done during release. (cherry picked from commit 5790f72)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 11, 2021
When we build production image during test in main, we install providers from current sources, to make sure that all the tests including Helm Chart/Kubernetes tests are using latest sources for providers. However, when we build the prod image during v* branches, we want to build the production image using latest released providers instead, because this will be the way it will be built shortly when we release it. We do not run providers test not helm chart tests in this branch so it is more important to build the image in the way it will be built for releases - we run verification then and install dependencies in the very same way it will be done during release. (cherry picked from commit 5790f72)
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
When we build production image during test in main, we install providers from current sources, to make sure that all the tests including Helm Chart/Kubernetes tests are using latest sources for providers. However, when we build the prod image during v* branches, we want to build the production image using latest released providers instead, because this will be the way it will be built shortly when we release it. We do not run providers test not helm chart tests in this branch so it is more important to build the image in the way it will be built for releases - we run verification then and install dependencies in the very same way it will be done during release. (cherry picked from commit 5790f72)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 17, 2021
When we build production image during test in main, we install providers from current sources, to make sure that all the tests including Helm Chart/Kubernetes tests are using latest sources for providers. However, when we build the prod image during v* branches, we want to build the production image using latest released providers instead, because this will be the way it will be built shortly when we release it. We do not run providers test not helm chart tests in this branch so it is more important to build the image in the way it will be built for releases - we run verification then and install dependencies in the very same way it will be done during release. (cherry picked from commit 5790f72)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we build production image during test in main, we install
providers from current sources, to make sure that all the tests
including Helm Chart/Kubernetes tests are using latest sources for
providers.
However, when we build the prod image during v* branches, we
want to build the production image using latest released providers
instead, because this will be the way it will be built shortly when
we release it. We do not run providers test not helm chart tests in
this branch so it is more important to build the image in the way it
will be built for releases - we run verification then and install
dependencies in the very same way it will be done during release.
Depends on #17486
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.