Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dag_maker in tests/core/test_core.py #17462

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

ephraimbuddy
Copy link
Contributor

This PR applies dag_maker to tests in test_core.py module


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@github-actions
Copy link

github-actions bot commented Aug 6, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Aug 6, 2021
This PR applies dag_maker to tests in test_core.py module
@uranusjr
Copy link
Member

uranusjr commented Aug 9, 2021

test_add_unparseable_file_before_sched_start_creates_import_error and test_mark_success_on_success_callback have been really flaky recently.

@uranusjr uranusjr merged commit daece96 into apache:main Aug 9, 2021
@uranusjr uranusjr deleted the test-core-use-dagmaker branch August 9, 2021 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants