-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ask for provider versions in bug reports #17480
Ask for provider versions in bug reports #17480
Conversation
We get a lot of bug reports for providers, and it's rare that the versions being used are in the initial report. Let's ask for them.
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
@@ -36,6 +36,13 @@ These questions are the first thing we need to know to understand the context. | |||
|
|||
**Apache Airflow version**: | |||
|
|||
**Apache Airflow Provider versions** (please include all providers that are relevant to your bug): | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually better advice will be 'airflow providers list' command output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL. That said, I think I prefer the output from pip as it doesn't have the description (assuming folks will copy/paste most likely). Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one difference is that providers list might contain more than community providers. Those are all registered ones which is discovered by scanning the entrypoints.
For issues in community we indeed care more about the community ones though. So i think both are fine and agree that description is not really needed in this case so pip freeze
will do its job well.
One other difference that airflow providers works also when you use INSTALL_PROVIDERS_FROM_SOURCES flag and providers are discovered from local sources rather than from packages (but this is not our case here)
We get a lot of bug reports for providers, and it's rare that the
versions being used are in the initial report. Let's ask for them.