-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure: New sftp to wasb operator #18877
Conversation
Hi! I had approval from @ephraimbuddy in this #14254 which contains the same code. |
airflow/providers/microsoft/azure/example_dags/example_sftp_to_wasb.py
Outdated
Show resolved
Hide resolved
airflow/providers/microsoft/azure/example_dags/example_sftp_to_wasb.py
Outdated
Show resolved
Hide resolved
airflow/providers/microsoft/azure/example_dags/example_sftp_to_wasb.py
Outdated
Show resolved
Hide resolved
docs/apache-airflow-providers-microsoft-azure/operators/sftp_to_wasb.rst
Outdated
Show resolved
Hide resolved
docs/apache-airflow-providers-microsoft-azure/operators/sftp_to_wasb.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor clean of typos and typing. Nice contribution! Thanks for all for the hard work here!
airflow/providers/microsoft/azure/example_dags/example_sftp_to_wasb.py
Outdated
Show resolved
Hide resolved
7eee706
to
5e2749a
Compare
cdb0d21
to
d98590e
Compare
docs/apache-airflow-providers-microsoft-azure/operators/sftp_to_wasb.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@josh-fell @uranusjr any further comments?
None from me. Nice addition to the Azure provider @wolvery! |
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>
Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>
Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>
Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>
Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>
Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>
d5141a9
to
f1441c1
Compare
closes: #9683
This operator helps to extract data from SFTP and load it to an Azure Wasb.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.