Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not check for S3 key before attempting download #19504

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Do not check for S3 key before attempting download #19504

merged 2 commits into from
Nov 10, 2021

Commits on Nov 10, 2021

  1. Do not check for key before attempting download 

    S3Hook.download_file first checks object existence then downloads.
This resolves creds 2 times.  We don't need to check existence.
Just ask for the key and if it's not there you'll know from the error.
And if it is there, you'll only have resolved creds once.
    @dstandish
    dstandish committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    2a03258 View commit details
    Browse the repository at this point in the history

  2. Update airflow/providers/amazon/aws/hooks/s3.py 

    Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
    @dstandish @kaxil
    dstandish and kaxil authored Nov 10, 2021
    Configuration menu
    Copy the full SHA
    8bf1f99 View commit details
    Browse the repository at this point in the history