Validate DagRun state is valid on assignment #19898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should avoid the most obvious user errors without too much overhead to the overall system.
2 tasks
ashb
approved these changes
Nov 30, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
approved these changes
Nov 30, 2021
ephraimbuddy
approved these changes
Nov 30, 2021
|
LOL tests are blowing up because a ton of them just set invalid DagRun states |
uranusjr
force-pushed
the
validate-dagrun-state
branch
from
179d03a
to
affc563
Compare
On the rare occasion we really need to initialize a DagRun with None state (for testing purposes), we can just skip setting state, since SQLAlchemy automatically initializes the declared_attr to None for us anyway.
uranusjr
force-pushed
the
validate-dagrun-state
branch
from
affc563
to
5607064
Compare
uranusjr
force-pushed
the
validate-dagrun-state
branch
from
35d8d1d
to
7950102
Compare
|
@uranusjr Thanks for putting the MR together! |
jedcunningham
pushed a commit
that referenced
this pull request
Dec 7, 2021
(cherry picked from commit 5b50d61)
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should avoid the most obvious user errors without too much overhead to the overall system. Nowhere near perfect, but if the user goes even lower level than this, they are obviously on their own.
Ref: #19836