Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated method call (blob.download_as_string) #20091

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

kazanzhy
Copy link
Contributor

@kazanzhy kazanzhy commented Dec 7, 2021

closes: #17800

Changed deprecated blob.download_as_string() to blob.download_as_bytes() in GCSHook.download()

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Dec 7, 2021
@kazanzhy
Copy link
Contributor Author

kazanzhy commented Dec 7, 2021

@lawrencestfs @uranusjr
Can you please have a look at these changes related to #17800?

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 7, 2021
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit 50bf536 into apache:main Dec 7, 2021
@kazanzhy kazanzhy deleted the fix_issue_17800 branch December 8, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQueryCreateExternalTableOperator from providers package fails to get schema from GCS object
4 participants