Organize EC2 classes in Amazon provider #20157
Conversation
boring-cyborg
bot
added
area:providers
provider:amazon-aws
eladkal
requested review from
ashb,
jedcunningham,
kaxil and
potiuk
as code owners
| @@ -263,6 +264,7 @@ sensors: | |||
| - integration-name: Amazon EC2 | |||
| python-modules: | |||
| - airflow.providers.amazon.aws.sensors.ec2_instance_state | |||
| - airflow.providers.amazon.aws.sensors.ec2 | |||
There was a problem hiding this comment.
Shouldn't we remove the line above this? or do we need to keep it until we remove it entirely?
There was a problem hiding this comment.
Removing it will cause failures for verify_provider_package.
pre-commits checks for comptability between yaml and modules found in the provider package.
removing the entries should be done when we remove the modules
There was a problem hiding this comment.
We have several of similar cases. For example:
airflow/airflow/providers/amazon/provider.yaml
Lines 312 to 314 in fa96b09
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
eladkal
removed
the
full tests needed
|
No need to waste CI resources for full test matrix for this change. |
Part of #20139
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.