rewrite opsgenie alert hook with official python sdk, related issue #18641

[pierrejeambrun]

Hello guys,

As suggested in this issue, I tried rewriting the opsgenie alert hook with the official python sdk. I also added an example dag for the opsgenie_alert_operator

This is my first contribution to Airflow, any guidance or feedback would be appreciated :). To not break the backward compatibility due to the interface change, do you want me to keep the original file and mark everything as deprecated and create another hook for this ?

Best regards,

resolves #18641

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[pierrejeambrun]

Just amended to fix checks.

[github-actions]

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

[potiuk]

Static checks failing (I heartily recommend pre-commit installation)

[pierrejeambrun]

@potiuk, thanks for that, I just installed them and fixed the provider-yamls pre-commit.

[eladkal]

LGTM

Can you please rebase ?
The test is failing on distutils which was fixed in #20420

[pierrejeambrun]

Yes of course, I juste rebased onto the latest main version.

[eladkal]

There is a still a failure
https://github.com/apache/airflow/runs/4591740391?check_suite_focus=true#step:6:865

You probably need to add a fix similar to https://github.com/apache/airflow/pull/20420/files
See the instructions in the test failure message

[pierrejeambrun]

Hi,

I have fixed that, and the job successfully ran locally, we should be good now.

We were missing warnings from fsspec.

[eladkal]

LGTM

@potiuk any further comments?

[eladkal]

@pierrejeambrun please check updated comment
I'll merge this PR after fixing it

[pierrejeambrun]

@eladkal We should be good 😄

[boring-cyborg]

Awesome work, congrats on your first merged pull request!

[eladkal]

Thanks @pierrejeambrun for your contribution!
If you are interested in taking another task check #8937 which is kinda similar

[pierrejeambrun]

My pleasure, it was really interesting helping on that.

I will try to first close my other PR #20386 that will certainly require more work. (I’ll also be OOO for a week)

After that if it is still available I can take it

[eladkal]

@pierrejeambrun you can comment on the issue and i'll assign you