Limit Snowflake connector to< 2.7.2 #20395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
mik-laj,
ephraimbuddy,
jedcunningham and
turbaszek
potiuk
changed the title
The Snowflake connector 2.7.2 requires pyarrow to be >=6.0.0 (but it has no "install_requires" for it - it checks it dynamically and prints warning when imported. We should limit the provider until apache-beam will remove the pyarrow < 6.0.0 limitation.
potiuk
force-pushed
the
limit-snowflake-provider
branch
from
3cf51ed
to
bd5efd9
Compare
|
BTW. This should be temporary measure - there is an apache-beam 2.3.5rc5 as of December 16th and there pyarrow is < 7.0.0 |
eladkal
approved these changes
Dec 18, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
91 tasks
potiuk
added a commit
that referenced
this pull request
Jan 22, 2022
The Snowflake connector 2.7.2 requires pyarrow to be >=6.0.0 (but it has no "install_requires" for it - it checks it dynamically and prints warning when imported. We should limit the provider until apache-beam will remove the pyarrow < 6.0.0 limitation. (cherry picked from commit 0050e44)
jedcunningham
pushed a commit
that referenced
this pull request
Jan 27, 2022
The Snowflake connector 2.7.2 requires pyarrow to be >=6.0.0 (but it has no "install_requires" for it - it checks it dynamically and prints warning when imported. We should limit the provider until apache-beam will remove the pyarrow < 6.0.0 limitation. (cherry picked from commit 0050e44)
jedcunningham
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Snowflake connector 2.7.2 requires pyarrow to be >=6.0.0
(but it has no "install_requires" for it - it checks it
dynamically and prints warning when imported.
We should limit the provider until apache-beam will remove the
pyarrow < 6.0.0 limitation.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.