Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy aws example dags #20497

Merged
merged 26 commits into from
Dec 30, 2021
Merged

Conversation

subkanthi
Copy link
Contributor

@subkanthi subkanthi commented Dec 25, 2021

Fixes mypy errors in aws/example_dags

related: #19891


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon-aws AWS/Amazon - related issues labels Dec 25, 2021
@subkanthi subkanthi marked this pull request as draft December 25, 2021 16:19
@subkanthi subkanthi marked this pull request as ready for review December 26, 2021 01:34
@potiuk
Copy link
Member

potiuk commented Dec 29, 2021

Now pre-commits - to add the missing licences :)

@subkanthi
Copy link
Contributor Author

Now pre-commits - to add the missing licences :)

Thanks , added now.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 29, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants