-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change download_video parameter to resourceName #20528
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There are some test failures:
|
Some tests are failing unfortunately :( |
Added mock for xcom_push support. Restored old way to provide resourse_name received from get_sdf_download_operation. Renamed operation to operation_state for clarity.
I fixed tests and ran them locally. Also I reverted changes in (I haven't tested these changes against real Google Cloud yet) |
Some static checks - I recommend installing pre-commit ! @mishc9 -> BTW. Is it possible you test it today? Then I could include that change in the December release of providers. |
Ok, I'll do pre-commit checks next time, thanks :) I'm not sure yet if I can test it today. It might happen after ~18:00 utc; but more likely tomorrow. |
tests/providers/google/marketing_platform/operators/test_display_video.py
Outdated
Show resolved
Hide resolved
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
If you can make a quick check today - fantastic, if not - we can test it in RC - i'd love to get that one included too in the release. |
Awesome work, congrats on your first merged pull request! |
I tried to test it using I'm quite new to Google Cloud, so the reason is obscure to me and it looks like I won't test these changes today unfortunately. Will try it later though :) |
The GoogleDisplayVideo360Hook.download_media hook tries to download media using the
"resource_name" argument. Changed parameter name in internal
download_media
call tothe "resourceName" according the API spec. Also changed parameter name in tests.
closes: #14077
related: #14077