Clarify docstring for build_pod_request_obj
#20574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unclear what was referred to by `pod` because there isn't a `pod` parameter. I attempt to replace with clearer (and accurate) information.
boring-cyborg
bot
added
provider:cncf-kubernetes
BasPH
reviewed
Dec 30, 2021
|
|
||
| Full pod spec overrides pod template, and operator params take highest precedence. |
There was a problem hiding this comment.
Would reverse the order so that the most important variable is mentioned first:
Suggested change
| Full pod spec overrides pod template, and operator params take highest precedence. | |
| The V1Pod attributes are selected from (first to last): operator params, full pod spec, pod template file. |
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
kaxil
added
changelog:skip
91 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unclear what was referred to by
podbecause there isn't apodparameter. I attempt to replace with clearer (and accurate) information.