Move pod_mutation_hook call from PodManager to KubernetesPodOperator #20596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
provider:cncf-kubernetes
Previously, in KubernetesPodOperator, the invocation of the pod mutation hook occurred within the call to PodManager.run_pod_async. So, `run_pod_async` would not quite run the pod you asked it to run, but would mutate it first. With this change, `run_pod_async` runs exactly the pod you request, and the pod returned by `build_pod_request_obj` is actually the pod you request.
dstandish
force-pushed
the
build-pod-obj-call-mutation-hook
branch
from
dc59857
to
eea190c
Compare
potiuk
approved these changes
Dec 30, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
91 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in KubernetesPodOperator, the invocation of the pod mutation hook occurred
within the call to PodManager.run_pod_async. So,
run_pod_asyncwould not quite runthe pod you asked it to run, but would mutate it first.
With this change,
run_pod_asyncruns exactly the pod you request, and the pod returnedby
build_pod_request_objis actually the pod you request.