Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dag_processing.processor_timeouts to counters section from gauges #23393

Conversation

yeachan153
Copy link
Contributor

closes: #21897

The metric dag_processing.processor_timeouts is incorrectly listed as a Gauge in the documentation, when in reality it is a counter.

@boring-cyborg
Copy link

boring-cyborg bot commented May 1, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@o-nikolas o-nikolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I wonder if there is an easy way to do a bulk grep for any other miss-labeled metrics 🤔

@github-actions
Copy link

github-actions bot commented May 3, 2022

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label May 3, 2022
@yeachan153
Copy link
Contributor Author

@uranusjr would you mind merging this as well please? I do not have permissions to merge this PR :)

@yeachan153
Copy link
Contributor Author

lgtm! I wonder if there is an easy way to do a bulk grep for any other miss-labeled metrics 🤔

Thanks for reviewing! I don't have any ideas to do that in bulk, LMK if you have any ideas 🙂

@potiuk potiuk merged commit fcfaa83 into apache:main May 8, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented May 8, 2022

Awesome work, congrats on your first merged pull request!

@ephraimbuddy ephraimbuddy added the type:doc-only Changelog: Doc Only label May 17, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.3.1 milestone May 17, 2022
ephraimbuddy pushed a commit that referenced this pull request May 17, 2022
ephraimbuddy pushed a commit that referenced this pull request May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation okay to merge It's ok to merge this PR as it does not require more tests type:doc-only Changelog: Doc Only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics documentation incorrectly lists dag_processing.processor_timeouts as a gauge
5 participants