-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move dag_processing.processor_timeouts to counters section from gauges #23393
Move dag_processing.processor_timeouts to counters section from gauges #23393
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! I wonder if there is an easy way to do a bulk grep for any other miss-labeled metrics 🤔
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
@uranusjr would you mind merging this as well please? I do not have permissions to merge this PR :) |
Thanks for reviewing! I don't have any ideas to do that in bulk, LMK if you have any ideas 🙂 |
Awesome work, congrats on your first merged pull request! |
(cherry picked from commit fcfaa83)
(cherry picked from commit fcfaa83)
closes: #21897
The metric
dag_processing.processor_timeouts
is incorrectly listed as a Gauge in the documentation, when in reality it is a counter.