Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backward compatibility for core__sql_alchemy_conn__cmd #23441

Merged
merged 2 commits into from
May 3, 2022

Conversation

c-thiel
Copy link
Contributor

@c-thiel c-thiel commented May 3, 2022

This adds backwards compatibility to use the __cmd option on core__sql_alchemy_conn which was lost in the 2.3.0 update.

closes: [#23408]
related: [#23408]

@boring-cyborg
Copy link

boring-cyborg bot commented May 3, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk added this to the Airflow 2.3.1 milestone May 3, 2022
@potiuk
Copy link
Member

potiuk commented May 3, 2022

Small static check probiem :)

@potiuk
Copy link
Member

potiuk commented May 3, 2022

Thanks for submitting that BTW!

@github-actions
Copy link

github-actions bot commented May 3, 2022

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label May 3, 2022
airflow/configuration.py Outdated Show resolved Hide resolved
@potiuk potiuk merged commit 0cdd401 into apache:main May 3, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented May 3, 2022

Awesome work, congrats on your first merged pull request!

@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label May 8, 2022
ephraimbuddy pushed a commit that referenced this pull request May 8, 2022
ephraimbuddy pushed a commit that referenced this pull request May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants