Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dag-processor fetch metabase config #23575

Merged
merged 1 commit into from
May 9, 2022

Conversation

Taragolis
Copy link
Contributor

Change [core] sql_alchemy_conn to [database] sql_alchemy_conn for dag-processor cli

closes: #23572, #23447


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label May 9, 2022
@github-actions
Copy link

github-actions bot commented May 9, 2022

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit 9837e6d into apache:main May 9, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented May 9, 2022

Awesome work, congrats on your first merged pull request!

@potiuk potiuk added this to the Airflow 2.3.1 milestone May 9, 2022
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label May 17, 2022
ephraimbuddy pushed a commit that referenced this pull request May 19, 2022
ephraimbuddy pushed a commit that referenced this pull request May 21, 2022
@Taragolis Taragolis deleted the fix-dag-processing-sql-alchemy-conn branch May 24, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CLI okay to merge It's ok to merge this PR as it does not require more tests type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli command dag-processor uses [core] sql_alchemy_conn
3 participants