-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flux to chart gitops docs #24288
Conversation
This also applies when using fluxCD for gitops.
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Added missing "----" to prevent checks from failing @rafagsiqueira |
FYI It works for RST were underlines are LONGER than text they underline, but RST breaks when they are SHORTER 🤯 |
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Awesome work, congrats on your first merged pull request! |
Thanks @rafagsiqueira! Congrats on your first commit 🎉 |
Hahahhaa! @jedcunningham thanks for the encouragement! Such a huge contribution I made to the project. Hahahhaha! I wish I had time to actually contribute. I love your project and I am really grateful to everyone who dedicate their time to it. |
Seriously though, a bunch of small contributions like this really does add up over time. Docs are really important for open source communities, and unfortunately the folks super involved are typically the worst ones to write docs because we have a bunch of domain knowledge already. It's hard to "look at it with fresh eyes" if that makes sense. So yeah, not the most earth shattering contribution, but you still made the chart docs a bit better and we appreciate it 🍺 |
It did take me at least a day to figure out why the migration job wasn’t running, so I hope it does help whoever comes after me. Flux is also the technology behind Azure arc-enabled clusters, so this might benefit a few people. 🍻 |
This also applies when using fluxCD for gitops.