Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flux to chart gitops docs #24288

Merged
merged 4 commits into from
Jun 13, 2022
Merged

Add Flux to chart gitops docs #24288

merged 4 commits into from
Jun 13, 2022

Conversation

rafagsiqueira
Copy link
Contributor

This also applies when using fluxCD for gitops.

This also applies when using fluxCD for gitops.
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 7, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

docs/helm-chart/index.rst Outdated Show resolved Hide resolved
@potiuk
Copy link
Member

potiuk commented Jun 7, 2022

Added missing "----" to prevent checks from failing @rafagsiqueira

@potiuk
Copy link
Member

potiuk commented Jun 7, 2022

FYI It works for RST were underlines are LONGER than text they underline, but RST breaks when they are SHORTER 🤯

docs/helm-chart/index.rst Outdated Show resolved Hide resolved
docs/helm-chart/index.rst Outdated Show resolved Hide resolved
rafagsiqueira and others added 2 commits June 13, 2022 15:57
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jun 13, 2022
@github-actions
Copy link

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@jedcunningham jedcunningham merged commit 5785d1d into apache:main Jun 13, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 13, 2022

Awesome work, congrats on your first merged pull request!

@jedcunningham jedcunningham changed the title Update index.rst Add Flux to chart gitops docs Jun 13, 2022
@jedcunningham
Copy link
Member

Thanks @rafagsiqueira! Congrats on your first commit 🎉

@jedcunningham jedcunningham added the type:doc-only Changelog: Doc Only label Jun 13, 2022
@rafagsiqueira
Copy link
Contributor Author

Hahahhaa! @jedcunningham thanks for the encouragement! Such a huge contribution I made to the project. Hahahhaha! I wish I had time to actually contribute. I love your project and I am really grateful to everyone who dedicate their time to it.

@jedcunningham
Copy link
Member

Seriously though, a bunch of small contributions like this really does add up over time. Docs are really important for open source communities, and unfortunately the folks super involved are typically the worst ones to write docs because we have a bunch of domain knowledge already. It's hard to "look at it with fresh eyes" if that makes sense.

So yeah, not the most earth shattering contribution, but you still made the chart docs a bit better and we appreciate it 🍺

@rafagsiqueira
Copy link
Contributor Author

It did take me at least a day to figure out why the migration job wasn’t running, so I hope it does help whoever comes after me. Flux is also the technology behind Azure arc-enabled clusters, so this might benefit a few people. 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart kind:documentation okay to merge It's ok to merge this PR as it does not require more tests type:doc-only Changelog: Doc Only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants