-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch sql_alchemy_conn if old Postgres schemes used #24569
Patch sql_alchemy_conn if old Postgres schemes used #24569
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
nice! |
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Thanks for approving PR @potiuk |
Awesome work, congrats on your first merged pull request! |
Some timeout issues. (we need to fix them soon BTW). |
cc @ephraimbuddy @jedcunningham -- We should include this in 2.3.3 |
(cherry picked from commit 0527a0b)
This PR fixed the unsupported
postgres://
schema since SQLAlchemy 1.4.It's an enhanced version of #22333.
It's specifically fixed an issue with Heroku default Postgres URI:
https://help.heroku.com/ZKNTJQSK/why-is-sqlalchemy-1-4-x-not-connecting-to-heroku-postgres
This is a blocker for the Airflow Heroku integration at that moment:
https://github.com/slyapustin/airflow-on-heroku