Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xcom_push flag from providers #24823

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Remove xcom_push flag from providers #24823

merged 1 commit into from
Jul 4, 2022

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented Jul 4, 2022

This is not a breaking change see #23981
If user use this flag the exception will be raised from BaseOperator:

raise AirflowException(
f"Invalid arguments were passed to {self.__class__.__name__} (task_id: {task_id}). "
f"Invalid arguments were:\n**kwargs: {kwargs}",


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst, in newsfragments.

@eladkal eladkal requested a review from potiuk July 4, 2022 10:50
@boring-cyborg boring-cyborg bot added provider:cncf-kubernetes Kubernetes provider related issues area:providers provider:amazon-aws AWS/Amazon - related issues labels Jul 4, 2022
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Not so nice message then, but nice enough and it's past time to do it already :)

@eladkal eladkal merged commit e2fd41f into apache:main Jul 4, 2022
@eladkal eladkal deleted the xcom branch July 4, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants