Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved telemetry for Databricks provider #25115

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Jul 17, 2022

This change adds to Databricks provider more details about version of Airflow & provider itself, so we can understand what Airflow & provider versions are used and plan backports, etc.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@alexott
Copy link
Contributor Author

alexott commented Jul 18, 2022

Hmmm, doesn’t understand why mypy started to fail - that part didn’t change

@potiuk
Copy link
Member

potiuk commented Jul 18, 2022

We just upgraded mypy and it's a bit more picky #25088.

Working on Airlfow's main is very much "living on the edge" :P

@potiuk
Copy link
Member

potiuk commented Jul 18, 2022

(same for static check on markdown - new markdown-lint is a bit more picky too - but I fixed this this morning - so rebasing should help).

@alexott alexott force-pushed the databricks-improved-telemetry branch from d8b60e6 to a147f0b Compare July 18, 2022 17:47
@potiuk
Copy link
Member

potiuk commented Jul 18, 2022

(the rebase to fix only applies to README markdown :). MyPy still needs fixing @alexott 😁

@alexott alexott force-pushed the databricks-improved-telemetry branch from a147f0b to b6393ab Compare July 24, 2022 12:00
@alexott
Copy link
Contributor Author

alexott commented Jul 24, 2022

Ok, I've fixed mypy errors in Databricks operator. But it's still failing in airflow/utils/context.py:235:

@potiuk potiuk force-pushed the databricks-improved-telemetry branch from 307106e to e7697ec Compare July 25, 2022 14:21
@potiuk
Copy link
Member

potiuk commented Jul 25, 2022

Yeah. Turned out to be nasty "werkzeug" problem.

@potiuk
Copy link
Member

potiuk commented Jul 25, 2022

Rebased to see if it is all green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants