Add optional data interval to CronTriggerTimetable #25503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mai-nakagawa
reviewed
Aug 3, 2022
uranusjr
force-pushed
the
cron-trigger-timetable-data-interval
branch
from
a59f47e
to
ea15e3a
Compare
mai-nakagawa
reviewed
Aug 4, 2022
This allows the user to provide a (static) data interval for DAG runs to adopt. This should be useful for most cron usages and more natural to the old schedule_interval logic. Also moved CronTriggerTimetable to its own module. The class living in 'interval' is weird.
uranusjr
force-pushed
the
cron-trigger-timetable-data-interval
branch
from
ea15e3a
to
4b013e4
Compare
mai-nakagawa
approved these changes
Aug 4, 2022
|
I prefer to do fixup commits for fixes that are not standalone to keep the history clean. I admit GitHub does not provide a very good UI for them, but the changes are still visible if you click on “force-pushed” in the message. |
ashb
reviewed
Aug 4, 2022
ashb
approved these changes
Aug 4, 2022
Oh, I missed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to provide a (static) data interval for DAG runs to adopt. This should be useful for most cron usages and more natural to the old schedule_interval logic. If
intervalis not provided, the default behaviour is the same as implemented in #23662.Also moved CronTriggerTimetable to its own module. The class living in
intervalis weird.cc @mai-nakagawa