Grid, fix toast for axios errors #25703
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error raised by axios (
AxiosError
) are not properly displayed in the toast. (Cf picture bellow).AxiosError
is a subclass ofError
and therefore handled as standardError
, never reading fromerror.response.data
but fromerror.message
.Added a check for Error deciding whether to read from
error.message
orerror.response.data
. (and removed the part that was never called after the Error check).Updated the tests accordingly. Axios does not expose a way to construct
AxiosError
manually. (enhanceError, createError, AxiosError are not exposed because they are part of axios core). I constructed a custom object with the correct properties to be considered as an AxiosError from axios type guard (axios.isAxiosError
). It is similar to whataxios.enhanceError
does. (If you have a better way to construct anAxiosError
, I'd be glad to take it).Before:
After: