Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow MapXComArg to resolve after serialization #26591

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Allow MapXComArg to resolve after serialization #26591

merged 2 commits into from
Sep 23, 2022

Commits on Sep 22, 2022

  1. More straightforward checks in test

    @uranusjr
    uranusjr committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    2251547 View commit details
    Browse the repository at this point in the history

  2. Allow MapXComArg to resolve after serialization 

    This is useful for cases where we want to resolve an XCom without
running a worker, e.g. to display the value in UI.

Since we don't want to actually call the mapper function in this case
(the function is arbitrary code, and not running it is the entire point
to serialize operators), "resolving" the XComArg in this case would
merely produce some kind of quasi-meaningful string representation,
instead of the actual value we'd get in the worker.

Also note that this only affects a very small number of cases, since
once a worker is run for the task instance, RenderedTaskInstanceFields
would store the real resolved value and take over UI representation,
avoiding this fake resolving logic to be accessed at all.
    @uranusjr
    uranusjr committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    2de0961 View commit details
    Browse the repository at this point in the history