Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remaining core sensors tests to pytest #28204

Merged

Conversation

Taragolis
Copy link
Contributor

@Taragolis Taragolis commented Dec 7, 2022

Second attempt (first: #28177, which reverted by #28196) of migration core sensors tests from to pytest

Also this PR include fix for task_runners tests which might affect other tests - initialize BaseRunner could lead issues with caplog operators logging records

@boring-cyborg boring-cyborg bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label Dec 7, 2022
@Taragolis
Copy link
Contributor Author

Locally it run successfully lets see how it deal in CI

root@60f341ac219e:/opt/airflow# pytest tests/task/task_runner tests/sensors/

...

================================ 130 passed, 2 skipped, 202 warnings in 65.90s (0:01:05) ================================

@Taragolis Taragolis requested review from potiuk and ashb December 7, 2022 20:16
@potiuk
Copy link
Member

potiuk commented Dec 8, 2022

Now we are cooking with gas :)

@potiuk potiuk merged commit e93b669 into apache:main Dec 8, 2022
@Taragolis Taragolis deleted the migrate-core-sensors-tests-to-pytest-2 branch December 8, 2022 13:50
ephraimbuddy pushed a commit that referenced this pull request Mar 8, 2023
ephraimbuddy pushed a commit that referenced this pull request Mar 9, 2023
ephraimbuddy pushed a commit that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants