Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a param for get_dags endpoint to list only unpaused dags #28713

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Add a param for get_dags endpoint to list only unpaused dags #28713

merged 5 commits into from
Feb 2, 2023

Conversation

hussein-awala
Copy link
Member

Add a param for get_dags endpoint to filter paused dags and list only unpaused dags.
(Stack Overflow question)

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jan 3, 2023
uranusjr
uranusjr approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only_* flags are starting to make me feel unconfortable and we might need a better parameter design at some point. (I don’t have a good idea in mind.)

ephraimbuddy
ephraimbuddy requested changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@ephraimbuddy ephraimbuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an improvement and not a bug fix, I moved it to 2.6.0

@hussein-awala hussein-awala requested review from ephraimbuddy and ashb and removed request for ryanahamilton, bbovenzi, mik-laj, ephraimbuddy and ashb January 4, 2023 22:30
ashb
ashb approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though should probably have some tests added

@hussein-awala
Copy link
Member Author

@ashb I just added the tests, can you re-check please?

@bbovenzi bbovenzi added this to the Airflow 2.6.0 milestone Jan 25, 2023
@bbovenzi
Copy link
Contributor

bbovenzi commented Feb 2, 2023

@hussein-awala Could you rebase and regenerate the yaml and typescript files please?

@hussein-awala
Copy link
Member Author

@bbovenzi done

@bbovenzi bbovenzi merged commit 8ce8c95 into apache:main Feb 2, 2023
@pierrejeambrun pierrejeambrun added type:new-feature Changelog: New Features type:improvement Changelog: Improvements and removed type:new-feature Changelog: New Features labels Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashb ashb ashb approved these changes

@uranusjr uranusjr uranusjr approved these changes

@ephraimbuddy ephraimbuddy ephraimbuddy approved these changes

@bbovenzi bbovenzi bbovenzi approved these changes

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:improvement Changelog: Improvements
Projects
None yet
Milestone
Airflow 2.6.0
Development

Successfully merging this pull request may close these issues.
6 participants
@hussein-awala @bbovenzi @ashb @uranusjr @ephraimbuddy @pierrejeambrun